[codex] Cache direct STL URL geometry loads#886
Open
newmattock wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
cachebust_originBufferGeometryper caller so component cleanup cannot dispose the cached templateSTLModelstlUrlpath through the cache while leaving directstlDataparsing unchangedSTLModelNon-overlap
The active PRs I found cover OBJ loader cache keys, GLTF/GLB loader caching, generic
load3DModelURL detection, and the STEP-to-GLB path. This PR only touches the directSTLModelstlUrlgeometry loading path.Verification
bun test tests/load-cached-stl-geometry.test.tsbunx tsc --noEmitbunx biome check src/three-components/STLModel.tsx src/utils/load-cached-stl-geometry.ts tests/load-cached-stl-geometry.test.tsgit diff --checkbun run buildAI-assisted with Codex; I reviewed the diff before submitting.