Cache shared 3D model loads#887
Open
starburtMr wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
/claim #93
Summary
load3DModeltemplate loads by normalized URL so duplicate model URLs share in-flight/completed loader work.cachebust_originfrom cache keys while preserving meaningful query params and hashes.model.glb?cachebust_origin=...and similar URLs route to the right loader.Validation
bun test tests/load-model.test.tsbunx biome check src/utils/load-model.ts tests/load-model.test.tsbunx tsc --noEmitbun run buildgit diff --checkNotes
bun testcurrently has unrelated existing failures intests/outline-bounds.test.tsandtests/preprocess-circuit-json.test.ts; the new focused loader tests pass.