Skip to content

Normalize OBJ loader cache keys#889

Open
sureshchouksey8 wants to merge 2 commits into
tscircuit:mainfrom
sureshchouksey8:normalize-obj-loader-cache-keys
Open

Normalize OBJ loader cache keys#889
sureshchouksey8 wants to merge 2 commits into
tscircuit:mainfrom
sureshchouksey8:normalize-obj-loader-cache-keys

Conversation

@sureshchouksey8
Copy link
Copy Markdown

Summary

  • Normalize OBJ loader cache keys by removing cachebust_origin instead of only matching an empty trailing parameter.
  • Sort remaining query parameters so duplicate EasyEDA model URLs share one in-flight/global cache entry.
  • Add Bun tests for cache-equivalent remote URLs and relative URLs.

Verification

  • npm run build
  • npx --yes bun test tests/normalize-obj-loader-cache-url.test.ts - 3 tests passed

/claim #93

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 14, 2026 11:35am

Request Review

Copy link
Copy Markdown
Author

Ready for review. The Vercel check is green, and local verification passed with:

  • npm run build
  • npx --yes bun test tests/normalize-obj-loader-cache-url.test.ts

The patch keeps the change focused on deduplicating OBJ loader cache keys for cache-equivalent EasyEDA model URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant