feat: add ccw_rotation to pcb_note_text for PCB note rotation#574
Open
64johnlee wants to merge 35 commits into
Open
feat: add ccw_rotation to pcb_note_text for PCB note rotation#57464johnlee wants to merge 35 commits into
64johnlee wants to merge 35 commits into
Conversation
added 10 commits
May 1, 2026 06:44
First test for circuit-json.
9 source schemas tested: - source_simple_resistor (3 tests) - source_simple_capacitor (3 tests) - source_simple_diode (1 test) - source_simple_led (1 test) - source_simple_fuse (2 tests) - source_simple_transistor (2 tests) - source_simple_power_source (2 tests) - source_simple_voltage_source (2 tests) - source_simple_current_source (2 tests) Total: 18 new tests.
+12 more tests for source schemas. All circuit-json tests passing.
+4 new tests (source_trace, source_component_internal_connection, source_project_metadata) All 252 circuit-json tests pass.
+6 tests. All 258 circuit-json tests pass.
+4 more tests. All 262 circuit-json tests pass.
+10 more schemas tested. All 272 circuit-json tests pass.
source_simple_chip, crystal, fiducial, ground, mosfet, port, connector, op_amp, battery, inductor All 282 circuit-json tests pass.
All 284 circuit-json tests pass.
64johnlee
commented
May 3, 2026
Author
64johnlee
left a comment
64johnlee
left a comment
There was a problem hiding this comment.
All checks passing ✅ This PR adds ccw_rotation support to pcb_note_text. Ready to merge! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
ccw_rotationproperty topcb_note_textschema and TypeScript interface to allow PCB note text elements to be rotated.Changes
ccw_rotationproperty using the existingrotationschema (supports number in degrees or string like "45deg")0(no rotation)Test Coverage
Added 4 test cases covering:
Issue
Fixes #531