fix: add zod transform to rename "round" to "circle" in pcb_hole#576
Open
64johnlee wants to merge 25 commits into
Open
fix: add zod transform to rename "round" to "circle" in pcb_hole#57664johnlee wants to merge 25 commits into
64johnlee wants to merge 25 commits into
Conversation
Add backward-compatible transform in pcb_hole_circle_or_square schema to accept legacy 'round' value and convert it to 'circle', matching the original fix in commit 14f8d3a that was lost during refactoring. Also export pcb_hole_circle_or_square schema for direct testing. Fixes tscircuit#42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #42
Add backward-compatible transform in
pcb_hole_circle_or_squareschema to accept legacyroundvalue and convert it tocircle, matching the original fix that was lost during the refactoring in commit e3e5a38.Changes:
.enum(["circle", "square", "round"]).default("circle").transform(...)tohole_shapefield inpcb_hole_circle_or_squareroundis passed, it is automatically converted tocirclepcb_hole_circle_or_squareschema for direct useTests added:
pcb_hole_circle_or_square accepts "circle" shapepcb_hole_circle_or_square accepts "square" shapepcb_hole_circle_or_square transforms "round" to "circle"All 219 tests pass, format clean.