Skip to content

Preserve wire attributes#435

Open
haim1120 wants to merge 1 commit into
tscircuit:mainfrom
haim1120:haim/preserve-wire-attributes
Open

Preserve wire attributes#435
haim1120 wants to merge 1 commit into
tscircuit:mainfrom
haim1120:haim/preserve-wire-attributes

Conversation

@haim1120
Copy link
Copy Markdown

Summary

  • Preserve DSN wire (attr ...), (shield ...), and (supply) metadata while parsing PCB wiring sections.
  • Emit preserved wire attributes from stringifyDsnJson so PCB parse -> stringify -> parse keeps the metadata.
  • Reuse the existing Wire type at the top-level DSN PCB wiring shape and add focused round-trip regression coverage.

Verification

  • bun test tests/dsn-pcb/wire-attributes.test.ts
  • bun test
  • bunx tsc --noEmit
  • bunx biome check lib/dsn-pcb/types.ts lib/dsn-pcb/dsn-json-to-circuit-json/parse-dsn-to-dsn-json.ts lib/dsn-pcb/circuit-json-to-dsn-json/stringify-dsn-json.ts tests/dsn-pcb/wire-attributes.test.ts
  • bun run build
  • git diff --check

/claim #54

Transparency note: AI-assisted with Codex; I reviewed the diff and verified it locally before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant