Skip to content

add schematic section#655

Merged
Sang-it merged 3 commits into
mainfrom
add-schematic-section
May 5, 2026
Merged

add schematic section#655
Sang-it merged 3 commits into
mainfrom
add-schematic-section

Conversation

@Sang-it
Copy link
Copy Markdown
Contributor

@Sang-it Sang-it commented May 5, 2026

No description provided.

@Sang-it Sang-it marked this pull request as ready for review May 5, 2026 16:57
Comment thread generated/COMPONENT_TYPES.md Outdated
key: z.any().optional(),
name: z.string(),
displayName: z.string().optional(),
schematicSectionReferenceName: z
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schematicSectionReferenceName: z
schSectionName:

Comment thread generated/COMPONENT_TYPES.md Outdated
schematicSectionReferenceName: z
.string()
.optional()
.describe("Assign membership to the referenced section."),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.describe("Assign membership to the referenced section."),
.describe("This component will be drawn as part of this section e.g. \"Power\""),

Comment thread lib/common/layout.ts Outdated
key: z.any().optional(),
name: z.string(),
displayName: z.string().optional(),
schematicSectionReferenceName: z
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schematicSectionReferenceName: z
schSectionName: z

Comment thread lib/common/layout.ts Outdated
schematicSectionReferenceName: z
.string()
.optional()
.describe("Assign membership to the referenced section."),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same this as other comment

Comment thread lib/components/schematic-section.ts Outdated

export const schematicSectionProps = z.object({
displayName: z.string().optional(),
referenceName: z.string(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
referenceName: z.string(),
name: z.string(),

Comment thread lib/components/schematic-section.ts Outdated

export interface SchematicSectionProps {
displayName?: string
referenceName: string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
referenceName: string
name: string

Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@Sang-it Sang-it merged commit 2956508 into main May 5, 2026
4 checks passed
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants