Skip to content

Map supported resistor footprint shorthands in resistorProps#662

Merged
techmannih merged 3 commits into
tscircuit:mainfrom
techmannih2:kaaa
May 7, 2026
Merged

Map supported resistor footprint shorthands in resistorProps#662
techmannih merged 3 commits into
tscircuit:mainfrom
techmannih2:kaaa

Conversation

@techmannih2
Copy link
Copy Markdown
Contributor

@techmannih2 techmannih2 commented May 7, 2026

Summary

  • move resistor footprint shorthand handling into resistorProps
  • map supported resistor footprint shorthands like 01005, 0402, and 2512 to res01005, res0402, and res2512
  • use an explicit allowlist of footprinter-supported resistor sizes instead of a generic numeric pattern
  • keep this behavior resistor-specific so shared footprint shorthands for other components are unchanged
  • preserve explicit footprints like kicad:R_0402_1005Metric without rewriting them
  • add tests for both shorthand mapping and passthrough behavior

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3643f052b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/components/resistor.ts Outdated
Comment thread lib/components/resistor.ts
@techmannih techmannih requested review from imrishabh18 and seveibar May 7, 2026 12:06
Copy link
Copy Markdown
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the context about why this change was needed.

@techmannih techmannih merged commit f856df1 into tscircuit:main May 7, 2026
4 checks passed
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants