add JLCPCB footprint autocomplete#670
Closed
techmannih wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/generated/jlcpcb-autocomplete.tsfrom the public jlcsearch APIFootprintPropjlcpcb:footprint selectors inpcbSxand update the footprint autocomplete type testWhy
JLCPCB footprint source strings were missing from the typed autocomplete/export surface, so consumers could not get first-class type support for
jlcpcb:footprint references.Impact
Consumers can now use
jlcpcb:C...footprint references with autocomplete/type safety, including footprint props and the matchingpcbSxselector path.Validation
bun scripts/generate-component-types.tsbun scripts/generate-manual-edits-docs.tsbun scripts/generate-readme-docs.tsbun scripts/generate-props-overview.tsbun scripts/generate-jlcpcb-autocomplete.tsbun testbun run typecheckbun run format:check