schematic view toggles

[seveibar]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
runframe	Ready	Preview, Comment	Jan 30, 2026 6:51am

[graphite-app]

The internal state is initialized with prop values but never updates when props change. If showSchematicDebugGridProp or showSchematicPortsProp change from the parent while handlers are not provided, the component will continue using stale values.

To fix, add useEffect to sync internal state with prop changes:

useEffect(() => {
  if (!onChangeShowSchematicDebugGrid) {
    setInternalShowSchematicDebugGrid(showSchematicDebugGridProp)
  }
}, [showSchematicDebugGridProp, onChangeShowSchematicDebugGrid])

useEffect(() => {
  if (!onChangeShowSchematicPorts) {
    setInternalShowSchematicPorts(showSchematicPortsProp)
  }
}, [showSchematicPortsProp, onChangeShowSchematicPorts])

This ensures props remain the source of truth even in uncontrolled mode.

Suggested change

	const [internalShowSchematicDebugGrid, setInternalShowSchematicDebugGrid] =
	useState(showSchematicDebugGridProp)
	const [internalShowSchematicPorts, setInternalShowSchematicPorts] = useState(
	showSchematicPortsProp,
	)
	const [internalShowSchematicDebugGrid, setInternalShowSchematicDebugGrid] =
	useState(showSchematicDebugGridProp)
	const [internalShowSchematicPorts, setInternalShowSchematicPorts] = useState(
	showSchematicPortsProp,
	)
	useEffect(() => {
	if (!onChangeShowSchematicDebugGrid) {
	setInternalShowSchematicDebugGrid(showSchematicDebugGridProp)
	}
	}, [showSchematicDebugGridProp, onChangeShowSchematicDebugGrid])
	useEffect(() => {
	if (!onChangeShowSchematicPorts) {
	setInternalShowSchematicPorts(showSchematicPortsProp)
	}
	}, [showSchematicPortsProp, onChangeShowSchematicPorts])

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[seveibar]

@Ayushjhawar8 this isn't working, can you look into it? we just need to get the view menu working so the user can toggle on schematic ports and stuff, there might be a keying issue or something idk https://schematic-viewer.vercel.app/?fixtureId=%7B%22path%22%3A%22examples%2Fexample17-schematic-ports.fixture.tsx%22%7D

[Ayushjhawar8]

onChangeShowSchematicDebugGrid={setShowSchematicDebugGrid}
onChangeShowSchematicPorts={setShowSchematicPorts}

i think we need to add these here aswell as without them, CircuitJsonPreview would using its internal state instead of RunFrame 's state, which might be causing the View menu toggles to be disconnected from the SchematicViewer.

[Ayushjhawar8]

[Ayushjhawar8]

@seveibar Please check

[seveibar]

nice