Cerulean Skyport & Deployment Fixes - #351
Conversation
135db91 to
e80c97c
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the MH-Tools population/export pipeline and bookmarklet state detection to support the Cerulean Skyport, while also adjusting Fungal Cavern phase handling and refactoring sample-size JSON diff processing and GitHub Pages deployment automation.
Changes:
- Add Cerulean Skyport “phase” detection in bookmarklet code and introduce Cerulean Skyport population definitions/CSVs.
- Refactor Fungal Cavern population configuration (stage as a default field) and regenerate its CSV output.
- Update sample-size diff fetching (cache-busting/no-cache headers) and refresh the GitHub Pages publishing workflow configuration.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/bookmarklet/bm-setup-fields.js | Updates location-phase logic for Fungal Cavern and adds Cerulean Skyport phase detection. |
| src/bookmarklet/bm-cre.js | Mirrors the phase detection updates for the CRE bookmarklet variant. |
| package.json | Adds a pop:skyport generator script and removes the puppeteer install helper script. |
| data/pop.js | Changes the minimum sample-size filter used during pop generation. |
| data/pop-js/fungal-cavern.js | Refactors Fungal Cavern pop definition to apply stage at the default level and reorganizes include lists. |
| data/pop-js/cerulean-skyport.js | Introduces Cerulean Skyport pop definition, including shipping and intercepting raid series. |
| data/pop-csv/fungal-cavern.csv | Regenerated Fungal Cavern population CSV with the updated phase breakdown. |
| data/pop-csv/cerulean-skyport.csv | Adds the new Cerulean Skyport population CSV output. |
| build/process-sample-size.js | Refactors sample-summary diff processing to use cache-busted/no-cache JSON fetches and removes puppeteer. |
| .github/workflows/publish.yml | Updates Pages workflow (Node version + action versions) and removes puppeteer step. |
Comments suppressed due to low confidence (2)
.github/workflows/publish.yml:61
actions/upload-pages-artifact@v5may not exist as a released major tag. If it's invalid, the workflow will fail when uploading the Pages artifact. Pin to a released major (or a commit SHA).
url: ${{ steps.deployment.outputs.page_url }}
permissions:
pages: write
id-token: write
.github/workflows/publish.yml:79
actions/deploy-pages@v5may not exist as a released major tag. If it's invalid, Pages deployment will fail. Pin to a released major (or a commit SHA).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Upgrade actions/checkout, actions/configure-pages, actions/setup-node, actions/upload-pages-artifact, and actions/deploy-pages to latest versions. - Refactor JSON fetching in process-sample-size.js to use a cache-busting mechanism and improve error handling. - Remove Puppeteer dependency from package.json as it's no longer needed.
e80c97c to
adff91e
Compare
|
I've fixed using Since I changed the workflow, the CI will not run on this target branch (intended). Further PRs will always use the workflow from the main branch until merged. |
Closes: #346