Skip to content

Cerulean Skyport & Deployment Fixes - #351

Merged
AardWolf merged 3 commits into
tsitu:masterfrom
hymccord:feat/cerulean-skyport
Jul 22, 2026
Merged

Cerulean Skyport & Deployment Fixes#351
AardWolf merged 3 commits into
tsitu:masterfrom
hymccord:feat/cerulean-skyport

Conversation

@hymccord

@hymccord hymccord commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
  • Add Cerulean Skyport pop
  • Simplfy FC standard cheese into Not Gemology
  • Update GitHub Actions and refactor sample size processing

Closes: #346

Copilot AI review requested due to automatic review settings July 21, 2026 19:28
@hymccord
hymccord force-pushed the feat/cerulean-skyport branch from 135db91 to e80c97c Compare July 21, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the MH-Tools population/export pipeline and bookmarklet state detection to support the Cerulean Skyport, while also adjusting Fungal Cavern phase handling and refactoring sample-size JSON diff processing and GitHub Pages deployment automation.

Changes:

  • Add Cerulean Skyport “phase” detection in bookmarklet code and introduce Cerulean Skyport population definitions/CSVs.
  • Refactor Fungal Cavern population configuration (stage as a default field) and regenerate its CSV output.
  • Update sample-size diff fetching (cache-busting/no-cache headers) and refresh the GitHub Pages publishing workflow configuration.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/bookmarklet/bm-setup-fields.js Updates location-phase logic for Fungal Cavern and adds Cerulean Skyport phase detection.
src/bookmarklet/bm-cre.js Mirrors the phase detection updates for the CRE bookmarklet variant.
package.json Adds a pop:skyport generator script and removes the puppeteer install helper script.
data/pop.js Changes the minimum sample-size filter used during pop generation.
data/pop-js/fungal-cavern.js Refactors Fungal Cavern pop definition to apply stage at the default level and reorganizes include lists.
data/pop-js/cerulean-skyport.js Introduces Cerulean Skyport pop definition, including shipping and intercepting raid series.
data/pop-csv/fungal-cavern.csv Regenerated Fungal Cavern population CSV with the updated phase breakdown.
data/pop-csv/cerulean-skyport.csv Adds the new Cerulean Skyport population CSV output.
build/process-sample-size.js Refactors sample-summary diff processing to use cache-busted/no-cache JSON fetches and removes puppeteer.
.github/workflows/publish.yml Updates Pages workflow (Node version + action versions) and removes puppeteer step.
Comments suppressed due to low confidence (2)

.github/workflows/publish.yml:61

  • actions/upload-pages-artifact@v5 may not exist as a released major tag. If it's invalid, the workflow will fail when uploading the Pages artifact. Pin to a released major (or a commit SHA).
      url: ${{ steps.deployment.outputs.page_url }}
    permissions:
      pages: write
      id-token: write

.github/workflows/publish.yml:79

  • actions/deploy-pages@v5 may not exist as a released major tag. If it's invalid, Pages deployment will fail. Pin to a released major (or a commit SHA).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/bookmarklet/bm-setup-fields.js
Comment thread src/bookmarklet/bm-cre.js
Comment thread src/bookmarklet/bm-setup-fields.js
Comment thread src/bookmarklet/bm-cre.js
Comment thread data/pop.js
Comment thread build/process-sample-size.js
hymccord added 3 commits July 21, 2026 15:41
- Upgrade actions/checkout, actions/configure-pages, actions/setup-node, actions/upload-pages-artifact, and actions/deploy-pages to latest versions.
- Refactor JSON fetching in process-sample-size.js to use a cache-busting mechanism and improve error handling.
- Remove Puppeteer dependency from package.json as it's no longer needed.
@hymccord
hymccord force-pushed the feat/cerulean-skyport branch from e80c97c to adff91e Compare July 21, 2026 19:41
@hymccord

hymccord commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

I've fixed using pull_request_target to use standard pull_request. I can't remember why I used it in the first place.

Since I changed the workflow, the CI will not run on this target branch (intended). Further PRs will always use the workflow from the main branch until merged.

@AardWolf
AardWolf merged commit a7998a3 into tsitu:master Jul 22, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security report — possible pull_request_target + checkout-head RCE (please contact privately)

3 participants