Skip to content

Ceiling improvements: banked resets, enforcement states, floatbar modes#46

Merged
tsouth89 merged 2 commits into
mainfrom
integration/passes-1-3
Jul 18, 2026
Merged

Ceiling improvements: banked resets, enforcement states, floatbar modes#46
tsouth89 merged 2 commits into
mainfrom
integration/passes-1-3

Conversation

@tsouth89

Copy link
Copy Markdown
Owner

Collapses three reviewed passes onto current main (1.0.0-rc.1) as one clean merge, per the plan. Supersedes #43, #44, #45 (each fully reviewed by adversarial subagents + CodeRabbit; all findings addressed). Only conflict was the English-only .ftl removals, resolved by accepting the deletion.

What's included

  • Codex banked resets (Verifiable reset notifications + Codex banked-resets 0-state #43): explicit "0 avail" chip (Codex-only, all 3 surfaces); backend records Some(0) instead of hiding it. Send test notification button that runs the real Windows toast pipeline and reports success/failure.
  • Explicit enforcement states — SOU-122 (Model explicit limit-window enforcement states (SOU-122) #44): EnforcementState { Tracked, NotEnforced, Unavailable } exposed to every surface without fabricating a %. A process-local, per-scope EnforcementTracker flags a core subscription window unavailable when it drops out of a successful response — sticky until it returns, core-windows-only (bonus pools never false-flag), scoped by provider|source|email|org, ignores errors.
  • Exact & Calm floatbar modes — SOU-178 (Add Exact and Calm information modes to the floating bar (SOU-178) #45): float_bar_information_mode (Exact default, safe migration). Calm leads with a trustworthy pace state + next reset; exact % on keyboard/click expand. Pace claimed only when live and actually supported.

Verification (against this main)

  • Rust codexbar lib 621, desktop crate 372 — 0 failures
  • Frontend 246 (48 files); tsc clean; locale-drift OK (English-only)

Review fixes folded in

Sticky/core-only tracker (one-shot bug), org-scoped observations, compact-density calm layout, calm aria-label matching visible state.

Collapses three reviewed passes (former PRs #43/#44/#45) onto current main
(1.0.0-rc.1), resolving the English-only .ftl removals. Full suites green:
Rust lib 621, desktop 372, frontend 246; tsc + locale-drift clean.

Codex banked resets (#43)
- Show the banked-reset count including an explicit "0", Codex-only, on all
  three surfaces; a successful fetch records Some(0) instead of hiding it.
- A "Send test notification" button that runs the real Windows toast
  pipeline synchronously and reports success/failure.

Explicit enforcement states — SOU-122 (#44)
- EnforcementState { Tracked, NotEnforced, Unavailable } on inactive
  windows, exposed through the bridge to every surface without fabricating
  a percentage.
- A process-local, per-scope EnforcementTracker marks a core subscription
  window "unavailable" when it drops out of an otherwise-successful
  response. Sticky until it returns; core windows only (bonus pools never
  false-flag); scoped by provider|source|email|org; ignores errors.
- ProviderDetailView / PlanStatusCard render the state distinctly.

Exact and Calm floatbar modes — SOU-178 (#45)
- float_bar_information_mode ("exact" default, safe migration). Calm leads
  with a trustworthy pace state + next reset; exact % on keyboard/click
  expand. Pace is only claimed when live and actually supported.

Includes review fixes: sticky/core-only tracker, org-scoped observations,
compact-density calm layout, and a calm aria-label that matches what's
shown. Reviewed by adversarial subagents and CodeRabbit.
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a3941e8-adde-4171-b218-ed21da2504c4

📥 Commits

Reviewing files that changed from the base of the PR and between 6b8ff38 and 819d8f1.

📒 Files selected for processing (42)
  • apps/desktop-tauri/src-tauri/permissions/commands.toml
  • apps/desktop-tauri/src-tauri/src/capacity_events.rs
  • apps/desktop-tauri/src-tauri/src/commands/bridge.rs
  • apps/desktop-tauri/src-tauri/src/commands/providers.rs
  • apps/desktop-tauri/src-tauri/src/commands/settings.rs
  • apps/desktop-tauri/src-tauri/src/commands/system.rs
  • apps/desktop-tauri/src-tauri/src/enforcement.rs
  • apps/desktop-tauri/src-tauri/src/floatbar/mod.rs
  • apps/desktop-tauri/src-tauri/src/main.rs
  • apps/desktop-tauri/src-tauri/src/state.rs
  • apps/desktop-tauri/src/App.test.tsx
  • apps/desktop-tauri/src/components/PlanStatusCard.test.tsx
  • apps/desktop-tauri/src/components/PlanStatusCard.tsx
  • apps/desktop-tauri/src/floatbar/FloatBar.css
  • apps/desktop-tauri/src/floatbar/FloatBar.test.tsx
  • apps/desktop-tauri/src/floatbar/FloatBar.tsx
  • apps/desktop-tauri/src/floatbar/SettingsSection.test.tsx
  • apps/desktop-tauri/src/floatbar/SettingsSection.tsx
  • apps/desktop-tauri/src/i18n/keys.ts
  • apps/desktop-tauri/src/lib/capacityPresentation.test.ts
  • apps/desktop-tauri/src/lib/capacityPresentation.ts
  • apps/desktop-tauri/src/lib/tauri.ts
  • apps/desktop-tauri/src/styles.css
  • apps/desktop-tauri/src/surfaces/PopOutPanel.test.tsx
  • apps/desktop-tauri/src/surfaces/ProviderDetailView.test.tsx
  • apps/desktop-tauri/src/surfaces/ProviderDetailView.tsx
  • apps/desktop-tauri/src/surfaces/TaskbarFlyout.tsx
  • apps/desktop-tauri/src/surfaces/TrayPanel.test.tsx
  • apps/desktop-tauri/src/surfaces/settings/tabs/AboutTab.test.tsx
  • apps/desktop-tauri/src/surfaces/settings/tabs/GeneralTab.test.tsx
  • apps/desktop-tauri/src/surfaces/settings/tabs/GeneralTab.tsx
  • apps/desktop-tauri/src/types/bridge.test.ts
  • apps/desktop-tauri/src/types/bridge.ts
  • docs/CEILING_UI.md
  • rust/src/core/usage_snapshot.rs
  • rust/src/locale.rs
  • rust/src/locale/en-US.ftl
  • rust/src/notifications.rs
  • rust/src/providers/codex/api.rs
  • rust/src/settings.rs
  • rust/src/settings/raw.rs
  • rust/src/settings/tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch integration/passes-1-3

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ceiling 819d8f1 Commit Preview URL

Branch Preview URL
Jul 18 2026, 01:42 AM

@tsouth89
tsouth89 merged commit 78537ef into main Jul 18, 2026
6 checks passed
@tsouth89
tsouth89 deleted the integration/passes-1-3 branch July 18, 2026 01:45
tsouth89 added a commit that referenced this pull request Jul 18, 2026
Version bump to **1.0.0-rc.2** across all locations (`version.env` build
92, both `Cargo.toml`s, `package.json`, `tauri.conf.json`, `Cargo.lock`)
plus the changelog section.

Ships the three reviewed passes merged in #46:
- Codex banked-reset display, including an explicit "0 available".
- "Send test notification" button (real Windows toast pipeline).
- Exact and Calm floating-bar information modes.
- Explicit "unavailable" state for a limit window that drops out of a
successful response.

After this merges and CI is green, an annotated `v1.0.0-rc.2` tag will
be pushed to trigger the signed-release workflow.

Co-authored-by: tsouth89 <tsouth89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant