Clarify 'Move config in' UI copy#355
Conversation
|
Hi @tsouth89 I have made only ui changes for this issue. My build is failing can u please check once ? |
tsouth89
left a comment
There was a problem hiding this comment.
Appreciate you taking this on, and the instinct is right. Move config in is a bit cryptic (in where?), so #268 is worth fixing.
One thing to reconsider though. Import into gateway collides with the existing Import action right above it. There are two separate buttons in that section. Import all copies a server in and leaves the client's own copy, so the tools load twice. Move config in copies it and then removes it from the client's config, so the gateway becomes the only source. That second one is the cutover, and the point is that it does more than an import.
With this rename the explainer ends up reading "Import copies a server... client keeps its own copy" right next to "Import into gateway copies it, then removes it...", two things both called Import, and a reader can't tell which is the safe copy and which is the destructive move. The Shuffle icon on the button also stops matching once the label says Import.
Could you keep it a Move? Something like Move into gateway or Migrate to gateway clears up the "in where" confusion from #268 while staying distinct from Import and matching the icon. Then update the same phrase in the explainer line and the warning below so they stay consistent.
The rest looks clean. Ping me if you want to nail down the wording.
📝 WalkthroughWalkthroughUpdates the import workflow wording in ChangesImport action copy
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ClientDetail.tsx`:
- Line 550: Update the three “Move into gateway” labels in ClientDetail to use
the exact wording “Import into gateway”, preserving the existing count
interpolation and surrounding UI behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6f9ba418-9218-4670-aba2-b95696b7c652
📒 Files selected for processing (1)
src/components/ClientDetail.tsx
| > | ||
| <Shuffle className="size-3" /> | ||
| Move config in ({movable.length}) | ||
| Move into gateway ({movable.length}) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the requested “Import into gateway” wording in all three locations.
The PR objective calls for replacing “Move config in” with “Import into gateway”, but these strings use “Move into gateway” instead. Please apply the exact requested copy consistently.
Proposed fix
- Move into gateway ({movable.length})
+ Import into gateway ({movable.length})
- <span className="font-medium text-foreground">Move into gateway</span>{" "}
+ <span className="font-medium text-foreground">Import into gateway</span>{" "}
- the gateway. Use <span className="font-medium">Move into gateway</span> to
+ the gateway. Use <span className="font-medium">Import into gateway</span> toAlso applies to: 566-566, 580-580
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/ClientDetail.tsx` at line 550, Update the three “Move into
gateway” labels in ClientDetail to use the exact wording “Import into gateway”,
preserving the existing count interpolation and surrounding UI behavior.
tsouth89
left a comment
There was a problem hiding this comment.
This is exactly it, thanks. Move into gateway keeps the Move/cutover meaning and stops colliding with Import. Merging.
What and why
Clarify the "Move config in" copy in the Client Details view.
ClientDetail.tsx. The updated wording makes the action easier for new users to understand while leaving the underlying behavior unchanged.Closes #268
Testing
npm run buildpassesnpm run testpassesnpm run audit:prodpassesnpm run test:rustpasses (npm run test:rust:windowson Windows if the debug gateway binary is locked)npm run tauri dev) and checked the change by hand