Skip to content

Clarify 'Move config in' UI copy#355

Merged
tsouth89 merged 2 commits into
tsouth89:mainfrom
BharadwajKanneveti:clarify-import-label
Jul 17, 2026
Merged

Clarify 'Move config in' UI copy#355
tsouth89 merged 2 commits into
tsouth89:mainfrom
BharadwajKanneveti:clarify-import-label

Conversation

@BharadwajKanneveti

Copy link
Copy Markdown
Contributor

What and why

Clarify the "Move config in" copy in the Client Details view.

  • This replaces the "Move config in" label with the clearer phrase "Import into gateway" across the three user-facing occurrences in ClientDetail.tsx. The updated wording makes the action easier for new users to understand while leaving the underlying behavior unchanged.

Closes #268

Testing

  • npm run build passes
  • npm run test passes
  • npm run audit:prod passes
  • npm run test:rust passes (npm run test:rust:windows on Windows if the debug gateway binary is locked)
  • Ran the app (npm run tauri dev) and checked the change by hand

@BharadwajKanneveti

Copy link
Copy Markdown
Contributor Author

Hi @tsouth89 I have made only ui changes for this issue. My build is failing can u please check once ?

@tsouth89 tsouth89 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you taking this on, and the instinct is right. Move config in is a bit cryptic (in where?), so #268 is worth fixing.

One thing to reconsider though. Import into gateway collides with the existing Import action right above it. There are two separate buttons in that section. Import all copies a server in and leaves the client's own copy, so the tools load twice. Move config in copies it and then removes it from the client's config, so the gateway becomes the only source. That second one is the cutover, and the point is that it does more than an import.

With this rename the explainer ends up reading "Import copies a server... client keeps its own copy" right next to "Import into gateway copies it, then removes it...", two things both called Import, and a reader can't tell which is the safe copy and which is the destructive move. The Shuffle icon on the button also stops matching once the label says Import.

Could you keep it a Move? Something like Move into gateway or Migrate to gateway clears up the "in where" confusion from #268 while staying distinct from Import and matching the icon. Then update the same phrase in the explainer line and the warning below so they stay consistent.

The rest looks clean. Ping me if you want to nail down the wording.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the import workflow wording in ClientDetail.tsx from “Move config in” to “Move into gateway” across the button, explanatory text, and connected-client warning, with no behavior changes.

Changes

Import action copy

Layer / File(s) Summary
Rename import action labels
src/components/ClientDetail.tsx
Changes the button, import explanation, and connected-client warning to use “Move into gateway” while preserving existing behavior and conditions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: syf2211, tsouth89

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: clarifying the "Move config in" UI copy.
Description check ✅ Passed The description is directly related to the copy update in ClientDetail.tsx and the intended behavior change is accurate.
Linked Issues check ✅ Passed The PR updates the three referenced copy strings in ClientDetail.tsx and keeps behavior unchanged, matching #268.
Out of Scope Changes check ✅ Passed The changes appear limited to UI wording in ClientDetail.tsx with no unrelated code or behavior changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/ClientDetail.tsx`:
- Line 550: Update the three “Move into gateway” labels in ClientDetail to use
the exact wording “Import into gateway”, preserving the existing count
interpolation and surrounding UI behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f9ba418-9218-4670-aba2-b95696b7c652

📥 Commits

Reviewing files that changed from the base of the PR and between b188bca and e16fa64.

📒 Files selected for processing (1)
  • src/components/ClientDetail.tsx

>
<Shuffle className="size-3" />
Move config in ({movable.length})
Move into gateway ({movable.length})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use the requested “Import into gateway” wording in all three locations.

The PR objective calls for replacing “Move config in” with “Import into gateway”, but these strings use “Move into gateway” instead. Please apply the exact requested copy consistently.

Proposed fix
-                  Move into gateway ({movable.length})
+                  Import into gateway ({movable.length})

-                  <span className="font-medium text-foreground">Move into gateway</span>{" "}
+                  <span className="font-medium text-foreground">Import into gateway</span>{" "}

-                the gateway. Use <span className="font-medium">Move into gateway</span> to
+                the gateway. Use <span className="font-medium">Import into gateway</span> to

Also applies to: 566-566, 580-580

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/ClientDetail.tsx` at line 550, Update the three “Move into
gateway” labels in ClientDetail to use the exact wording “Import into gateway”,
preserving the existing count interpolation and surrounding UI behavior.

@tsouth89 tsouth89 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly it, thanks. Move into gateway keeps the Move/cutover meaning and stops colliding with Import. Merging.

@tsouth89
tsouth89 merged commit bbb6259 into tsouth89:main Jul 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify the Move-config-in label copy

2 participants