chore(dashboards): rename cerberus-self.json to cerberus.json and drop subtitle#713
Closed
tsouza wants to merge 1 commit into
Closed
chore(dashboards): rename cerberus-self.json to cerberus.json and drop subtitle#713tsouza wants to merge 1 commit into
tsouza wants to merge 1 commit into
Conversation
Owner
Author
|
Folded into #701 (cerberus-self → cerberus rename rides with the other 3 dashboard renames there) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User feedback: compose-stack dashboards should use bare subject names — no
-observability/-self-observabilitysuffix.test/e2e/grafana/compose/dashboards/cerberus-self.jsontocerberus.json(git-tracked rename, history preserved).test/e2e/grafana/dashboards/cerberus-self.json.title:field fromCerberus - self-observabilityto plainCerberus.uid: "cerberus-self"so the/d/cerberus-selfURL keeps working (Grafana provisioning keys off UID, not filename or title).Reference updates
docker-compose.yml—GF_DASHBOARDS_DEFAULT_HOME_DASHBOARD_PATH+ service comment.test/e2e/grafana/compose/dashboards-provider.yaml— file mention in the provider comment.test/e2e/k3s/grafana-dashboards.yaml— file mention + ConfigMap name (grafana-dashboard-cerberus-self→grafana-dashboard-cerberus) + ConfigMap data key (cerberus-self.json→cerberus.json) + the embedded dashboardtitle.test/e2e/k3s/grafana.yaml— volumeconfigMap.namereference matching the renamed ConfigMap.test/e2e/k3s/cerberus.yaml— comment.docs/observability.md— path reference.internal/api/admit/admit.go,internal/telemetry/metrics.go— prose comments.test/regression/k3s_env_test.go— assertion message + comment.test/e2e/playwright/{compose_grafana_smoke,iterate-all-dashboards,iterate-histogram-completeness,iterate-metrics-explorer,iterate-panel-kiosk,iterate-panel-shape,iterate-time-ranges}.spec.ts+helpers/{sweep.ts,README.md}— prose-only comments. The/d/cerberus-selfURLs incompose_grafana_smoke.spec.tsare UID-based and were intentionally not touched.test/spec/promql/sum_by_rate_{range_step,dotted_source}.txtar+test/spec/logql/matcher_self_service.txtar— fixture header comments.Test plan
compose-smoke(the dashboard is provisioned from the renamed file and served viaGF_DASHBOARDS_DEFAULT_HOME_DASHBOARD_PATH).dashboardsmoke against k3d (renamed ConfigMap + data key consumed bygrafana.yaml).check,lint,forbid-skip, compatibility, roundtrips).🤖 Generated with Claude Code