chore(compat/loki): drop 4 stale detected_level should_skip entries#714
Merged
Conversation
The 4 `detected_level` entries in cerberus-test-queries.yml carried a "harness seed-gap" rationale claiming the seeder doesn't push structured-metadata input for reference Loki to index. That rationale was stale: PR #412 wired structured-metadata into the seeder via `pushLoki`'s `logproto.LabelAdapter` block (compatibility/loki/cmd/seed/main.go), and loki-config.yaml has `allow_structured_metadata: true`. PR #712's compat run on this branch confirms parity: all four cases report `diff: ""` against the reference Loki: - regression/structured-metadata.yaml#Combined line and metadata filter - regression/structured-metadata.yaml#Drilldown with failed search and error level - regression/structured-metadata.yaml#Drilldown with error/warn level and refused search - exhaustive/aggregations.yaml#Count aggregated by detected_level Dropping these 4 entries promotes them out of the overlay back into the compat denominator with verified reference baselines. The remaining 20 entries (upstream `skip: true` rows + the `pod` / `namespace` / `service_name` / `cluster` / `container` seed-gap entries) stay as-is — those are separate from the structured-metadata cluster. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 4
detected_levelentries incompatibility/loki/cerberus-test-queries.ymlcarried a "harness seed-gap" rationale claiming the seeder doesn't push
structured-metadata input for the reference Loki to index. That rationale
was stale. PR #412 wired structured-metadata into the seeder via
pushLoki'slogproto.LabelAdapterblock incompatibility/loki/cmd/seed/main.go(every entry now carries
StructuredMetadata: [{Name: "detected_level", Value: <lvl>}]),and
loki-config.yamlalready hasallow_structured_metadata: true.PR #712 (which empties the entire
should_skipblock) ran on top of theseentries' removal and reported
diff: ""against the reference Loki for allfour — verified independently from the artifact:
regression/structured-metadata.yaml#Combined line and metadata filterregression/structured-metadata.yaml#Drilldown with failed search and error levelregression/structured-metadata.yaml#Drilldown with error/warn level and refused searchexhaustive/aggregations.yaml#Count aggregated by detected_levelDropping these 4 entries promotes them out of the overlay back into the
compat denominator with verified reference baselines. The closure is a
documentation/overlay cleanup, not a seeder change — the seeder code
path was already correct, just the rationale was stale.
The remaining 20 entries stay as-is:
skip: truerows (numeric label filters /stddev_over_time/quantile_over_timenot supported by Loki's v2 engine).pod/namespace/service_name/cluster/containerlabels (separate cluster; tracked separately).Test plan
compatibility/lokigreen — the 4 lifted entries now contributeparity baselines to the score.
check/lintgreen — YAML-only change, no Go code touched.🤖 Generated with Claude Code