Show result types on trace nodes#58
Open
rogierx wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
args.results.typeIdagainst traceTypeLineentries and attaching the referenced result type to each trace tree node.=> #id display, with the full type in the tooltip when it is truncated.Validation
pnpm run typecheckpnpm exec vitest run test/index.test.tspnpm exec eslint src/traceTypes.ts src/traceTree.ts shared/src/messages.ts ui/components/TreeNode.vue test/index.test.tspnpm run generate:contributes,pnpm --dir srcDev run build,pnpm --dir ui run build,pnpm exec rollup -cNote: the local machine policy blocks the repo-level
pnpm run buildbecause itsnrwrapper tries to acquire a newer package-manager toolchain through Corepack, so I ran the equivalent build steps directly with the installed pnpm.