Label realtime and trace diagnostics#65
Open
rogierx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #50.
This makes tsperf diagnostics identify which measurement pipeline produced them:
Realtime tsserver: ...and use sourcetsperf realtimeTrace check: ...and use sourcetsperf traceThat should make confusing warnings easier to triage, especially when deciding whether a warning came from trace metrics or realtime tsserver measurements.
The branch also removes package-manager caching from the tag-triggered release workflow so the publish/release path does not rely on shared caches.
Validation:
pnpm exec vitest run test/index.test.tspnpm run typecheckpnpm exec eslint src/diagnosticText.ts src/index.ts src/traceDiagnostics.ts test/index.test.tspnpm exec rollup -cgit diff --check