Add two-stage trace filtering#76
Open
100more wants to merge 1 commit into
Open
Conversation
Author
|
Confirmed the full CI-style test command locally after this scope clarification:
The command ran the pretest build/lint chain and then Vitest completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two-stage trace filtering
Summary
Addresses #41.
Why this is low-risk
Files changed
src/treeFilters.ts- added: shared helpers for filter lists, path exclusions, and visible child branchessrc/traceTree.ts- modified: filters expanded child nodes with active webview child/path filtersshared/src/messages.ts- modified: adds defaulted filterTree child/path fieldssrc/handleMessages.ts- modified: passes new filterTree fields to trace tree renderingui/app.vue- modified: adds child trace and path preset filter controlstest/index.test.ts- modified: covers filter-list parsing, path exclusion, and child-branch matchingCoverage
Verification
pnpm exec vitest run test/index.test.ts- passedpnpm run typecheck- passedpnpm exec eslint src/treeFilters.ts src/traceTree.ts src/handleMessages.ts shared/src/messages.ts ui/app.vue test/index.test.ts- passedpnpm lint- passedpnpm build- passedgit diff --check- passedCI=1 pnpm test- passedReviewer notes
Boundary note
No payment, account, secret, or private contact details are included in this PR.