Update dependencies to their latest versions#48
Open
lsfgrd wants to merge 1 commit intotsuru:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to update the dependencies to their latest versions available as of today.
Reasoning:
I had some problems setting the project up with the latest LTS Node version. When I went to check out the dependencies, I saw that they were very outdated. This makes sense since it's an old project, but it doesn't help new contributors since the README doesn't specify this needs a specific Node version to run the old packages.
What was done:
MAKEFILEto install SASS and Grunt's CLIs with withnpm -g(thus removing the need to have Ruby installed, which was also causing me problems to run);READMEto reflect this new reality.Let me know what you think :-)