refactor: simplify clenshaw summations - #175
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors how the complex longitude phase terms (exp(1j*m*phi)) are generated for Clenshaw-style spherical harmonic summations, and updates CI path filters so Python tests run when additional top-level packages change.
Changes:
- Refactors
exp(1j*m*phi)construction in bothsea_level_equationandclenshaw_summationto a fully-vectorizednp.exp(...)computation. - Renames the
_clenshawreturn variable froms_m-style naming tocs_mfor consistency with callers. - Expands the
.github/workflows/python-request.ymlpull_request path filters to include additional package directories.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gravity_toolkit/sea_level_equation.py | Precomputes m_phi via vectorized exponentials outside the iterative solver loop. |
| gravity_toolkit/clenshaw_summation.py | Vectorizes m_phi generation and renames _clenshaw internal/return variable to cs_m. |
| .github/workflows/python-request.yml | Triggers the Python workflow on changes in more top-level source directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
refactor: `ruff` format ci: add `ruff` format check
|
@copilot review the updated |
Reviewed the current committed state at |
No description provided.