Switch database to Postgres - #9
Merged
Merged
Conversation
ttnsy
commented
Jun 19, 2026
ttnsy
commented
Owner
- Replace production db to Postgres
- Use sqlite only to run tests
Gotfrid
requested changes
Jun 22, 2026
Gotfrid
left a comment
Gotfrid
left a comment
Collaborator
There was a problem hiding this comment.
Please apply changes we discussed on the call
ttnsy
force-pushed
the
postgres_migration
branch
from
July 24, 2026 07:56
5ffec27 to
948faf4
Compare
ttnsy
force-pushed
the
postgres_migration
branch
from
August 7, 2026 07:55
948faf4 to
8951a74
Compare
Gotfrid
approved these changes
Aug 7, 2026
Gotfrid
left a comment
Gotfrid
left a comment
Collaborator
There was a problem hiding this comment.
left some nitpick comments, approving to unblock
|
|
||
| class Settings(BaseSettings): | ||
| db_path: str = DEFAULT_DB_PLACEHOLDER | ||
| engine: Literal["sqlite", "postgres"] = Field(default="sqlite") |
Collaborator
There was a problem hiding this comment.
suggestion: consider explicit alias, but not necessary
… unnecessary engine disposal in test fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.