Fix cgmerge to handle call graphs with null meta field#41
Fix cgmerge to handle call graphs with null meta field#41silas-martens wants to merge 1 commit intotudasc:develfrom
Conversation
jplehr
left a comment
There was a problem hiding this comment.
Please add a test for this case
From what I understand, the existing tests in My idea is to add a separate folder inside |
|
As @silas-martens said, there are currently no explicit test cases for |
|
I'm OK with requiring the new tool for the functionality that cgpatch does. It simply sounded as if this is a general bug, and so this would be a general fix. So, my question is: What's stopping us from adding a test case that uses cgmerge and have one of the input files trigger the previous error? My understanding was that this currently crashes the tool, which I think should not happen. |
CGMergecan now handle call graphs where the meta field is null. This is necessary to merge the patch graphs generated bycgpatch.