This repository was archived by the owner on Jul 28, 2018. It is now read-only.
Use session cookies instead - #643
Open
ivanxuu wants to merge 1 commit into
Open
Conversation
By default all cookies generated in turbolinks via javascript are generated with no expiration date. It would be better to use session cookies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default all cookies generated in turbolinks via javascript are generated with no expiration date. It would be better to use session cookies.
Related to ISSUE #641
The reason why I think is better to have a session cookie is because of the european cookies law in Europe, only first‑party session cookies DO NOT require informed consent. Otherwise the website should bother the user with the 'We inform you that this website use cookies..' message.