Skip to content
This repository was archived by the owner on Sep 25, 2021. It is now read-only.

Set "Turbolinks-Location" header when redirecting from routes - #17

Open
artemave wants to merge 2 commits into
turbolinks:masterfrom
artemave:master
Open

Set "Turbolinks-Location" header when redirecting from routes#17
artemave wants to merge 2 commits into
turbolinks:masterfrom
artemave:master

Conversation

@artemave

@artemave artemave commented Nov 6, 2016

Copy link
Copy Markdown

So that turbolinks in the browser updates the url.

turbolinks/turbolinks#169

@Fudoshiki

Copy link
Copy Markdown

merge?

@kaspergrubbe

Copy link
Copy Markdown

I think I am still seeing this issue in 5.2.0.

@artemave

Copy link
Copy Markdown
Author

@rafaelfranca merge?

@mensfeld

mensfeld commented Oct 6, 2019

Copy link
Copy Markdown

Can confirm in 6.0.0

@emilkarl

Copy link
Copy Markdown

Is this supposed to be merged or is there other ways to solve this now?

@artemave

Copy link
Copy Markdown
Author

@sstephenson merge?

@hgeorgilas

Copy link
Copy Markdown

Is this going to be merged at some point?

@tomclose

tomclose commented May 7, 2021

Copy link
Copy Markdown

I've just run into this too. The current behaviour isn't compatible with stimulus reflex: if you use redirect(...) to a page using stimulus reflex, you'll run into errors Reflex SearchReflex#perform failed: No route matches ....

It would be really handy if turbolinks changed the urls when using redirect from the routes file. @rafaelfranca is there any reason not to merge this? (Not clear to me that this solution works anymore. As a workaround, I'm avoiding using redirect in the routes file and instead rewriting to use redirect_to in a controller action.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants