Kaelin Sleevi#70
Open
KaelinSleevi wants to merge 52 commits into
Open
Conversation
Comment on lines
+33
to
+48
| 1. Try to guess what elsif and else are doing. | ||
| - I would guess elsif is being used or is giving a second possibilty for another true or false statement. Else is a third option if neither the if or elsif statements are true. | ||
| 2. Change the numbers of cars, people, and trucks, and then trace through each if-statement to see what will be printed. | ||
| - If people is changed to 50 the printed would be: | ||
| - "We should not take the cars." | ||
| - "Maybe we could take the trucks." | ||
| - "Alright, let's just take the trucks" | ||
| - If cars is changed to 10 the printed would be: | ||
| - "We should not take the cars." | ||
| - "That's too many trucks." | ||
| - "Alright, let's just take the trucks." | ||
| - If trucks changed to 30 the printed would be: | ||
| - "We should take the cars." | ||
| - "Maybe we could take the trucks." | ||
| - "Fine, let's stay home then." | ||
| 3. Try some more complex boolean expressions like cars > people || trucks < cars. |
There was a problem hiding this comment.
Since this is a .rb file, your computer interprets everything in here as Ruby . You should use the pound sign to comment out things that are not Ruby (like what I highlighted, and other spots).
corneliusellen
left a comment
corneliusellen
left a comment
There was a problem hiding this comment.
Nice work on this @KaelinSleevi. I can tell you have a solid understanding of Ruby syntax, datatypes, and conventions. Please see my comments and I would encourage you to adjust anything that should be fixed.
| 2. student_count_integer: | ||
| - This could be a good variable, but the "integer" part is not necessary. The student count will be an integer either way. You can make it shorter without the excess word. | ||
| 3. homeworkAssignment | ||
| - This is a bad variable and is invalid in ruby. It uses camel_case rather than snake_case. It should be homework_assignment |
Edit and revise Mod 0 project
|
@KaelinSleevi Changes look good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my finished M1 Prework!