Open
Conversation
The MPEG-TS pts field can roll over after a stream has been on for a sufficiently long time (e.g. a week or so). There was a failsafe built into the demuxer that would prevent PTS from ever decreasing -- this was because normally PTS is not supposed to decrease (outside of rollovers). This change now assumes that the data stream will be passed in order in order to maintain that PTS condition. Issue #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes logic that prevented
ptsfrom ever decreasing. This means that whenptsrolls over during a very long stream the demuxer will reflect the new pts. It is the responsibility of the consuming code to handle this event.Related Issues
Resolves #18