Fix underlines with larger line-heights - #143
Open
mpasalic wants to merge 2 commits into
Open
Conversation
Owner
|
Do you have a screen at hand to demo the edge case? |
Collaborator
Author
Good idea, sorry I didn't think of doing that right away. I just updated the description. Btw, I guess one other hacky fix for this edgecase would be to keep the lineheight normal when the entire line is a link. Basically, only apply the shorter lineheight when it won't cause this glitch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a better solution eventually, but just made it so the underlined text itself doesn't have a super large line-height. This works great in almost every case except when the line only is a link. That line will be shorter than most and the second you write some other text (that's not underlined) it will jump to a larger height.
Not sure if I'm happy with this, but decided to push as a PR and see what you think.
(I know you said to punt on this, but just wanted to see if a quick solution worked alright).
underline_fix_edgecase.mov