Skip local variant detection for remote URL images#865
Open
William-Laverty wants to merge 1 commit intotwostraws:mainfrom
Open
Skip local variant detection for remote URL images#865William-Laverty wants to merge 1 commit intotwostraws:mainfrom
William-Laverty wants to merge 1 commit intotwostraws:mainfrom
Conversation
When an Image is initialized with a remote URL (http/https), skip the local filesystem variant detection (findVariants) that looks for @2x and ~dark alternatives in the assets directory. This avoids spurious 'Could not read the assets directory' warnings when using remote images. Fixes twostraws#864.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an
Imageis initialized with a remote URL (http/https), skip the local filesystem variant detection (findVariants) that searches for@2xand~darkalternatives in the assets directory.Problem
As noted in #864, remote URLs already work with
Image, but Ignite attempts to find local file variants for them — scanning the assets directory for density and appearance alternatives. This is unnecessary for remote images and produces warnings when the assets directory doesn't contain matching files.Fix
isRemoteflag torender(path:description:)that skipsfindVariants()entirely forhttp/httpsURLs.markup()by checking the URL scheme.This is a minimal, targeted change — remote images emit a clean
<img>tag without triggering filesystem operations.Fixes #864.