Conversation
Pre-production review found leakage in the public KP:1 specification
repo. The "Nova" codename is internal-only, and EXTENSIONS.md
described kp-forge / kp-packs / kp-viewer as "the public" reference
implementation, which is factually wrong (only kp is public today).
- EXTENSIONS.md: drop the "(the public kp-forge, kp-packs, and
kp-viewer repositories)" parenthetical; the catalogue still
describes producer-defined extensions in active use across the
reference implementation, just without naming the private repos.
- DEFINITIONS.md, CHANGELOG.md, SPEC.md: replace "Nova ecosystem"
and "Nova IDs" prose with neutral phrasing ("the reference
implementation", "canonical entity IDs"). No normative content
change — these were intent annotations.
Tool names (kp-forge, kp-packs, kp-viewer) are retained as
descriptive references; only the workspace codename and the
factually-wrong "public" attribution were scrubbed.
Co-Authored-By: Claude <noreply@anthropic.com>
…e use cases Add six new purpose values (pre_meeting, hiring, partnership, competitive_intel, sales_prep, appreciation) and six new domain_lens values (hr_reviewer, partner_evaluator, competitor_analyst, admirer, meeting_host, salesperson) to PLAYBACK.md section 3. Mark both enums as extensible in new section 3.3: renderers MUST fall back to orientation / general for unknown values, so newer pack profiles don't crash older renderers and new values can ship via spec updates without coordinated viewer rebuilds. Refs: sessions/2026-05-19-research-framing-broadening/SESSION.md Co-Authored-By: Claude <noreply@anthropic.com>
Collections P1 (2026-05-24). Documents the extensions.collection block on PACK.yaml: name, id, role (hub/member/standalone) plus the new item_kind / item_role inventory taxonomy. item_kind is a 9-value controlled vocabulary (spine, subcollection, object, person, place, period, event, document, narrative) that the viewer's inventory dashboard uses to bucket packs into sections. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Docs-only PR that fast-forwards main to include recent public KP:1 spec documentation updates (extensions catalogue expansion, PLAYBACK enum broadening, and scrubbing “Nova”/internal phrasing) so downstream consumers can reference the commit via origin/main.
Changes:
- Document
extensions.collectionand its controlleditem_kindtaxonomy inEXTENSIONS.md. - Expand and explicitly document
AudienceProfile.purposeandAudienceProfile.domain_lensenums (with extensibility rules) inPLAYBACK.md. - Replace remaining “Nova ecosystem/IDs” phrasing with “reference implementation” / “canonical entity IDs” in core spec text and changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/SPEC.md | Updates deprecated entities.md guidance wording to “canonical entity IDs”. |
| spec/PLAYBACK.md | Documents expanded purpose/domain_lens enums and extensibility behavior. |
| spec/EXTENSIONS.md | Adds extensions.collection extension documentation and inventory taxonomy. |
| spec/DEFINITIONS.md | Replaces “Nova ecosystem” phrasing with “reference implementation”. |
| spec/CHANGELOG.md | Aligns changelog wording with “reference implementation” and “canonical entity IDs”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+83
to
+85
| The `domain_lens` field names the listener's role-frame. Original five | ||
| values (`buyer`, `consigner`, `compliance`, `journalist`, `collector`, | ||
| `general`) are joined by six use-case-named values added 2026-05-19: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three docs-only commits land in the public KP:1 spec. All currently sit on
dev; this PR fast-forwardsmainso the Nova workspace's submodule pointer (which references the tip of these changes) is reachable fromorigin/main.docs(extensions): add extensions.collection with item_kind taxonomy— documents theextensions.collectionblock (name, id, role hub/member/standalone) and the 9-value item_kind controlled vocabulary the viewer's inventory dashboard buckets packs by.docs(playback): broaden purpose + domain_lens enums for non-compliance use cases— adds six new purpose values (pre_meeting, hiring, partnership, competitive_intel, sales_prep, appreciation) and six domain_lens values; both enums marked extensible with fallback to orientation/general.docs(spec): scrub internal references from public spec— drops the "Nova" codename and the "kp-forge / kp-packs / kp-viewer" parenthetical from public docs (onlykpitself is public).Why now
Nova's submodule pin for
repos/kpis atae1a946, which until this push existed only locally + ondev. A clean Nova clone with--recursivewould fail to fetch the spec pointer. Merging here makes it reachable fromorigin/main(the canonical reference).Test plan
git -C repos/kp branch -r --contains ae1a946showsorigin/main