Fix timing attack vulnerability in MQTT ticket signature verification - #161
Fix timing attack vulnerability in MQTT ticket signature verification#161tyronechrisharris wants to merge 1 commit into
Conversation
Updated `MqttTicketUtils.java` to use `MessageDigest.isEqual` for comparing the expected signature with the provided signature. This replaces the use of `String.equals`, which is susceptible to timing attacks, with a constant-time comparison method. This ensures that the time taken to verify a ticket signature does not depend on the content of the signature, preventing attackers from potentially forging signatures by measuring verification times. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Evaluated the token authentication logic (
MqttTicketUtils.java) and found a timing attack vulnerability where the expected HMAC-SHA256 signature was being compared to the provided signature usingString.equals(). This has been fixed by switching to a constant-time comparison utilizingMessageDigest.isEqual()to compare the byte arrays, preventing attackers from gaining information about the valid signature through timing side-channels. Relevant tests were run and passed successfully.PR created automatically by Jules for task 9454492276376693784 started by @tyronechrisharris