Skip to content

Include reference to section id for conditionals #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaha-digital wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include reference to section id for conditionals #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jQuery(function($) {
var $this = $(this);

// add a tab head link for each tab
tabsHead.append('<a href="#">' + $this.find('.gsection_title').html() + '</a>');
// add the id as well so gf conditional sections still works
Copy link
Copy Markdown
Owner

@tyxla tyxla Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we'd want to keep the original comment here?

tabsHead.append('<a id="' + $this[0].id + '" href="#">' + $this.find('.gsection_title').html() + '</a>');
Copy link
Copy Markdown
Owner

@tyxla tyxla Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rewrite $this[0].id in a safer way, for example $this.attr('id') (untested)?

Copy link
Copy Markdown
Author

@kaha-digital kaha-digital Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes much easier, ill merge that in soon

Copy link
Copy Markdown
Author

@kaha-digital kaha-digital Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i dont actually know how to merge these changes into my pull request, but your suggestion works - no problems.

Copy link
Copy Markdown
Owner

@tyxla tyxla Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can assist with updating your PR if that'll be helpful for you.

Copy link
Copy Markdown

@recyclingrules recyclingrules Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys -- I'm new to GitHub, so apologize if this is a stupid question. It appears you've made some modifications that fixes those of us that have "conditional sections". How do I get the modified code? Is the modified code limited to just js/main.js and it's just a matter of copying the file? What is a pull request? At what point does a new "version" of the plugin become available with the modified code?

Copy link
Copy Markdown
Owner

@tyxla tyxla Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy @recyclingrules, this link should allow you to download the modified code:

https://github.com/gubbigubbi/gravity-forms-section-tabs/archive/77d323d649df0594352e9ca698d47d08601a611b.zip

In the meantime, I'd be happy to assist with landing this one if @gubbigubbi would need some help. I'll probably do that anyway if we don't get any movement soon.

Copy link
Copy Markdown

@mastef mastef Oct 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gubbigubbi you just commit the changes to your branch and they will be added to your PR

Copy link
Copy Markdown
Author

@kaha-digital kaha-digital Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mastef I have commited the changes to my branch. Please feel free to merge :)

Copy link
Copy Markdown
Owner

@tyxla tyxla Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gubbigubbi did you also push to the remote? I'm not seeing any recent changes here.

Copy link
Copy Markdown

@mastef mastef Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gubbigubbi you need to git push them now


// move the corresponding fields to their tab body
var gformFields = $('<ul class="gform_fields">');
Expand Down