Skip to content

Fix for BC break in goaop/framework #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JJCLane wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for BC break in goaop/framework #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a0735d
Fix for BC break in goaop/framework
JJCLane Aug 12, 2025
5a078a6
Merge pull request #214 from JJCLane/master
Naktibalda Aug 15, 2025
240a63e
Fix callable syntax for PHP 8.2
JJCLane Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/AspectMock/Intercept/BeforeMockTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use Go\Aop\Aspect;
use Go\Instrument\Transformer\StreamMetaData;
use Go\Instrument\Transformer\TransformerResultEnum;
use Go\Instrument\Transformer\WeavingTransformer;
use Go\ParserReflection\ReflectionFile;
use Go\ParserReflection\ReflectionMethod;
Expand All @@ -15,9 +16,9 @@ class BeforeMockTransformer extends WeavingTransformer
protected string $before = " if ((\$__am_res = __amock_before(\$this, __CLASS__, __FUNCTION__, array(%s), false)) !== __AM_CONTINUE__) return \$__am_res; ";
protected string $beforeStatic = " if ((\$__am_res = __amock_before(get_called_class(), __CLASS__, __FUNCTION__, array(%s), true)) !== __AM_CONTINUE__) return \$__am_res; ";

public function transform(StreamMetaData $metadata): string
public function transform(StreamMetaData $metadata): TransformerResultEnum
{
$result = self::RESULT_ABSTAIN;
$result = TransformerResultEnum::RESULT_ABSTAIN;
$reflectedFile = new ReflectionFile($metadata->uri, $metadata->syntaxTree);
$namespaces = $reflectedFile->getFileNamespaces();

Expand Down Expand Up @@ -75,7 +76,7 @@ public function transform(StreamMetaData $metadata): string
do {
if (($metadata->tokenStream[$tokenPosition]->text ?? '') === '{') {
$metadata->tokenStream[$tokenPosition]->text .= $beforeDefinition;
$result = self::RESULT_TRANSFORMED;
$result = TransformerResultEnum::RESULT_TRANSFORMED;
break;
}
$tokenPosition++;
Expand Down
2 changes: 1 addition & 1 deletion src/AspectMock/Util/ArgumentsFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ final class ArgumentsFormatter
{
public static function toString($args): string
{
return implode(',',array_map('self::format', $args));
return implode(',',array_map([self::class, 'format'], $args));
}

protected static function format($arg)
Expand Down