start supporting client credentials auth #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
commented
Feb 25, 2025
| &mut self, | ||
| login_endpoint: impl AsRef<str>, | ||
| ) -> Result<&mut Self, Error> { | ||
| self.set_login_endpoint(login_endpoint.as_ref()); |
Author
There was a problem hiding this comment.
I'm not sure if I like that part, feel free to recommend any other design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also https://help.salesforce.com/s/articleView?id=xcloud.remoteaccess_oauth_client_credentials_flow.htm&type=5
This was missing and we needed it, I assume it's also useful for others.
I'm happy to implement any needed changes.
( not time critical, we worked around it by fetching the token ourselves, and using
set_access_token)