Symfony Migration - Programmify Symfony Command Execution #2152
+112
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow us to execute Symfony commands programmatically as opposed to using `exec` to start a new process. This means that we are not dependent on there being a `bin/console` file being present.
Since this logic is used in a number of places I've refactored it into helper class that can then be used instead of duplicating code.
ryanrath
force-pushed
the
programmify-command-execution
branch
from
58b1886 to
437054a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SymfonyCommandHelper::executeCommand.GeneralSetupto useSymfonyCommandHelper::executeCommand.DotEnvConfigMigrationto useSymfonyCommandHelper::executeCommandMotivation and Context
These changes allow us to execute Symfony commands programmatically as
opposed to using
execto start a new process. This means that we arenot dependent on there being a
bin/consolefile being present.Tests performed
All
Checklist: