fix(ci): fail hung unit tests and run build in parallel - #701
Merged
Conversation
## Summary ### Why? Build and Unit Test on PR CI sat on `//service/runway/server:go_default_test` until Bazel's 300s timeout because a consumer test sent a message with no tenant. After tenant sharding the consumer rejects that delivery before Process, so the nack path never closed `done`. `make test` then swallowed the Bazel failure with `|| echo`, so the job still went green. ### What? Set `Tenant` on the mock message so the delivery reaches Process. Drop the `|| echo` so `make test` fails when Bazel does. Add `--build_tests_only` and remove the extra `make build` step from that CI job; `bazel test` already compiles what the tests need. ## Test Plan ✅ `bazel test //service/runway/server:go_default_test` PASSED in 5.5s (was TIMEOUT 300s) Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
marked this pull request as ready for review
September 11, 2026 05:53
## Summary ### Why? A sequential `make build` then `make test` made the unit-test job wait on a full compile that tests already cover. Dropping build entirely skipped the compile-only gate (`bazel build //...`). ### What? Split Build and Unit Test into two jobs that start together. Build still runs `make build`. Unit Test still runs `make test` with `--build_tests_only`. Required Checks waits on both. Each job keeps its own Bazel cache key (`github.job`). ## Test Plan CI on this PR: Build and Unit Test jobs run concurrently; Required Checks includes both. Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
changed the title
mnoah1
approved these changes
Sep 11, 2026
behinddwalls
enabled auto-merge
September 11, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
A sequential
make buildthenmake testmade the unit-test job wait on a full compile that tests already cover. Dropping build entirely skipped the compile-only gate (bazel build //...).What?
Split Build and Unit Test into two jobs that start together. Build still runs
make build. Unit Test still runsmake testwith--build_tests_only. Required Checks waits on both. Each job keeps its own Bazel cache key (github.job).Test Plan
CI on this PR: Build and Unit Test jobs run concurrently; Required Checks includes both.
Co-authored-by: Cursor cursoragent@cursor.com