feat: support branch-scoped preview deployments + cleanup by lustsazeus-lab · Pull Request #16 · ubiquity/deno-deploy-workflow

lustsazeus-lab · 2026-03-03T23:44:57Z

Summary

This PR implements branch-scoped preview deployments for the reusable Deno Deploy workflow, plus automatic cleanup support when branches are deleted.

Changes

Added preview_strategy input to deno-deploy-reusable.yml
- default: branch
- optional legacy mode: shared
Branch preview naming now derives from branch refs (slugified + length-safe hash fallback)
- example: feat/widget + pay-ubq-fi -> feat-widget-pay-ubq-fi
Router preview URL computation now supports branch-specific hosts (<branch>-<subdomain>.ubq.fi)
Added reusable cleanup workflow:
- .github/workflows/deno-deploy-preview-cleanup.yml
- deletes branch preview projects on delete-triggered runs
Updated README with usage docs for:
- preview_strategy
- delete-event cleanup integration

Validation

./.tools/actionlint/actionlint ✅

Fixes #7
/claim #7

coderabbitai · 2026-03-03T23:45:05Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 41beacbd-3019-441f-87d2-a86db8901169

📥 Commits

Reviewing files that changed from the base of the PR and between c8e1400 and c750009.

📒 Files selected for processing (2)

.github/workflows/deno-deploy-preview-cleanup.yml
.github/workflows/deno-deploy-reusable.yml

📝 Walkthrough

Walkthrough

Adds a new reusable GitHub Actions workflow (deno-deploy-preview-cleanup.yml) to delete Deno Deploy preview projects on branch deletion. The cleanup workflow validates inputs, computes or accepts the preview project name (with branch/shared strategies, slugging, truncation and sha1 suffixing), can skip deletion for production branches, and issues a DELETE to the Deno API (treating 404 as success). The deployment workflow gains preview_strategy (default branch), branch slugging, length/hash handling, router_host and branch_slug outputs, and URL resolution preferring ROUTER_HOST. README updated accordingly.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding branch-scoped preview deployments and automatic cleanup for the Deno Deploy workflow.
Description check	✅ Passed	The description is directly related to the changeset, detailing branch-scoped previews, cleanup workflow, and README updates with validation confirmation.
Linked Issues check	✅ Passed	The PR meets all objectives from issue `#7`: supports branch-name prefixes for preview hostnames, creates separate projects per branch, detects deletions, and auto-deletes corresponding projects.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to issue `#7`: new reusable workflows, preview strategy logic, router URL computation, and documentation updates align with stated objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e18a3d0ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-03T23:48:58Z

+              if [ $max_branch_len -lt 6 ]; then
+                echo "::error::Cannot build branch preview name for base '${base}' within Deno project length limits"


Avoid hard-failing branch previews for longer project names

Because preview_strategy now defaults to branch, this check causes preview deployments to fail for any valid project whose base name is longer than 12 characters (for example notifications-ubq-fi, where max_branch_len becomes 5). Existing repos that do not explicitly opt back to shared will start failing on non-production branches, even though those previews previously deployed successfully.

Useful? React with 👍 / 👎.

…t names When a project's base name is too long (e.g. notifications-ubq-fi with base='notifications'), max_branch_len becomes <6, making branch-based preview naming impractical (0-char branch slug + hash = ugly leading hyphens like '-a1b2c-notifications-ubq-fi'). Instead of exiting with an error, fall back to shared preview naming silently so repos with long names don't break after upgrading without having to explicitly set strategy=shared. P1 feedback from chatgpt-codex-connector[bot] on PR ubiquity#16.

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ed9b06fe-0992-41fd-96de-0cea0c9b7c1c

📥 Commits

Reviewing files that changed from the base of the PR and between 9c32848 and 27cbead.

📒 Files selected for processing (3)

.github/workflows/deno-deploy-preview-cleanup.yml
.github/workflows/deno-deploy-reusable.yml
README.md

… naming - deno-deploy-reusable.yml: Add explicit 'strategy=shared' block to handle the case where strategy is explicitly set to 'shared' with mode=preview. Previously the preview variable was never set in this case, causing DNS-validation to fail on an empty string. Now shared strategy (whether explicit or auto-switched due to long branch names) is handled consistently. - deno-deploy-preview-cleanup.yml: Align empty-slug handling with deploy workflow. When slugify returns empty, fall back to 'preview' slug (like deploy does) instead of silently skipping. Also add auto-switch to shared strategy when max_branch_len < 6, consistent with deploy behavior. - README.md: Document the auto-fallback-to-shared behavior for repos with very long base names that cannot fit any branch preview prefix.

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 95a0b676-1b7a-4d93-8144-1871c9a53bfc

📥 Commits

Reviewing files that changed from the base of the PR and between 27cbead and c8e1400.

📒 Files selected for processing (3)

.github/workflows/deno-deploy-preview-cleanup.yml
.github/workflows/deno-deploy-reusable.yml
README.md

✅ Files skipped from review due to trivial changes (2)

README.md
.github/workflows/deno-deploy-reusable.yml

… project deletion Address CodeRabbit feedback: - Validate preview_strategy is 'branch' or 'shared' in both deno-deploy-reusable.yml and deno-deploy-preview-cleanup.yml; fail fast on unknown values to prevent the wrong preview project from being deleted. - Add explicit guard in cleanup workflow: refuse to DELETE the production project if target resolves to the base project name (prevents catastrophic deletion). Fixes remaining issues from ubiquity#16 CodeRabbit review.

nagiexplorer88 · 2026-05-13T17:05:36Z

There is still a branch-collision case in the default branch strategy.

In both the deploy and cleanup workflows, when the base project name leaves fewer than six chars for the branch prefix, the code switches strategy="shared":

suffix="-${base}-ubq-fi"
max_branch_len=$((26 - ${#suffix}))
if [ $max_branch_len -lt 6 ]; then
  strategy="shared"
fi

For a repo like the comment's own example notifications-ubq-fi, base=notifications, so suffix=-notifications-ubq-fi is 21 chars and max_branch_len is 5. That means preview_strategy: branch silently falls back to p-notifications-ubq-fi / preview-notifications.ubq.fi, so feat/a and fix/b still deploy to the same preview target instead of separate branch-scoped previews.

This seems to miss the core requirement from #7: "support any branch as the prefix instead of collapsing all of them into preview- prefixes." It probably needs a deterministic shortened/hashed base for long project names, or should fail loudly instead of silently reverting to shared preview mode.

feat: support branch-scoped preview projects and cleanup

0e18a3d

This was referenced Mar 3, 2026

All Branches Supported for Previews #7

Open

All Branches Supported for Previews devpool-directory/devpool-directory#5899

Open

chatgpt-codex-connector Bot reviewed Mar 3, 2026

View reviewed changes

RyanAI and others added 2 commits March 4, 2026 07:56

style(ci): satisfy actionlint shellcheck output grouping

659062f

coderabbitai Bot requested changes Apr 8, 2026

View reviewed changes

Comment thread .github/workflows/deno-deploy-preview-cleanup.yml

Comment thread .github/workflows/deno-deploy-reusable.yml

Comment thread README.md

coderabbitai Bot requested changes Apr 8, 2026

View reviewed changes

Comment thread .github/workflows/deno-deploy-preview-cleanup.yml

Comment thread .github/workflows/deno-deploy-preview-cleanup.yml

coderabbitai Bot approved these changes Apr 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support branch-scoped preview deployments + cleanup#16

feat: support branch-scoped preview deployments + cleanup#16
lustsazeus-lab wants to merge 5 commits into
ubiquity:mainfrom
lustsazeus-lab:feat/issue-7-branch-previews

lustsazeus-lab commented Mar 3, 2026

Uh oh!

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading

Walkthrough

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 3, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

nagiexplorer88 commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if [ $max_branch_len -lt 6 ]; then
		echo "::error::Cannot build branch preview name for base '${base}' within Deno project length limits"

Conversation

lustsazeus-lab commented Mar 3, 2026

Summary

Changes

Validation

Uh oh!

coderabbitai Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nagiexplorer88 commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading