Update parts to last versions#349
Conversation
kenvandine
left a comment
There was a problem hiding this comment.
One inline comment on an extra blank line, otherwise this looks fine.
6d2139e to
26729b0
Compare
|
Still feel it's a bit risky to switch to very new stable versions of gtk and friends, especially because we should also update the themes (yaru) with it. However, I'd like to get #344 to land first so at least we can have some CI testing now |
|
@3v1n0 If you prefer, I can go back for glib, gobject-introspection, gtk4, glibmm and gtkmm... |
JGCarroll
left a comment
There was a problem hiding this comment.
Just wondering if we could maybe tweak the Glycin parts on the assumption it might be easy.
This include libcroco, because GTK4 requires it and downloads its own version if it's not available in the system, but then librsvg fails to build. Installing our own libcroco fixes this. Tested with: * Firefox * Cheese * Chromium * Darktable * Element-desktop * Epiphany * Evince * Gimp * Gnome-Characters * Gnome-Mines * Gnome-Recipes * Kicad * Shotwell * Telegram-Desktop * Mattermost-desktop All of them work fine.
26729b0 to
638fdb1
Compare
|
Ok, these are the stable versions from January 17, so they are the previous stables to the current ones... |
aleasto
left a comment
There was a problem hiding this comment.
I would at least update to the latest patch releases. Some are more important than others.
|
CI hates me, for sure :-D |
|
@kenvandine What do you say? Approve? |
This include libcroco, because GTK4 requires it and downloads its own version if it's not available in the system, but then librsvg fails to build.
Installing our own libcroco fixes this.
Tested with:
All of them work fine.