Open
Conversation
Contributor
|
It is usually very annoying to have the later steps depend on INPUT_CONFS. |
Contributor
Author
|
I thought the workaround for that is to just use Not sure how I can parse out just the sram-generator-output.json without adding a weird special case here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, hierarchical steps did not see a dependence on inputs.yml, sram-generator-output.json, and your INPUT_CONFS in the hierarchical flow.
A bug could occur if the hierarchical module contained its own SRAM macro that no leaf module included. Without appending to p_syn_in, sram-generator-output.json would not be included, and the tools would not be able to resolve the path to this macro.