Small change to allow workflow to use convention-aware magnitudes without # ty: ignore

[AndrewRidden-Harper]

Small change to allow workflow to use convention-aware magnitudes without # ty: ignore.

[gemini-code-assist]

Code Review

This pull request updates the nshmdb library to use the BoldM class from source_modelling for parent fault magnitudes, updating type annotations, docstrings, and tests, while also pinning source-modelling>=2026.6.2 in requirements.txt. The feedback suggests using Mapping[str, Union[float, BoldM]] instead of dict[str, BoldM] for the parent_fault_magnitudes parameter to avoid static type-checking issues with invariant dictionaries, along with corresponding import and docstring updates.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Import Mapping and Union from typing to support a more flexible type signature for parent_fault_magnitudes that accepts both standard float and BoldM values.

Suggested change

	from source_modelling.moment import BoldM
	from typing import Mapping, Union
	from source_modelling.moment import BoldM

[gemini-code-assist]

By changing the type annotation of parent_fault_magnitudes from dict[str, float] to dict[str, BoldM], any existing or future callers passing a standard dict[str, float] will trigger static type-checking errors (since dict is invariant in Python).

To allow both float and BoldM (or other magnitude conventions) without type-checking issues, use Mapping[str, Union[float, BoldM]]. Since Mapping is covariant in its value type, this will seamlessly accept both dict[str, float] and dict[str, BoldM] without requiring any # type: ignore comments.

    def most_likely_fault(
        self,
        rupture_id: int,
        parent_fault_magnitudes: Mapping[str, Union[float, BoldM]],
    ) -> dict[str, float]:

[gemini-code-assist]

Update the docstring to reflect that parent_fault_magnitudes can accept either standard float values or BoldM convention objects.

Suggested change

	parent_fault_magnitudes : dict[str, BoldM]
	A mapping of parent fault names to their expected magnitudes (in the
	`BoldM` convention). These magnitudes define the target values for
	querying activity rates in the MFD table.
	parent_fault_magnitudes : Mapping[str, Union[float, BoldM]]
	A mapping of parent fault names to their expected magnitudes (either as
	floats or in the `BoldM` convention). These magnitudes define the target
	values for querying activity rates in the MFD table.