Skip to content

Fix typing - #378

Merged
claudio525 merged 3 commits into
masterfrom
typing_fix
Aug 11, 2026
Merged

Fix typing#378
claudio525 merged 3 commits into
masterfrom
typing_fix

Conversation

@claudio525

Copy link
Copy Markdown
Contributor

No description provided.

@claudio525

Copy link
Copy Markdown
Contributor Author

@claude review

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown

Claude Code is working…

I'll analyze this and get back to you.

View job run

@claudio525

Copy link
Copy Markdown
Contributor Author

@claude review

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown

Claude Code is working…

I'll analyze this and get back to you.

View job run

@claudio525

Copy link
Copy Markdown
Contributor Author

@claude review

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown

Claude finished @claudio525's task in 48s —— View job


Review complete ✅

  • Gather context (diff, CLAUDE.md, prior review comments)
  • Review changed files for correctness bugs
  • Post findings

Findings: 0 (no correctness bugs found)

The change is a small, self-consistent typing fix:

  • qcore/coordinates.py: distance_between_wgs_depth_coordinates now wraps the scalar branch's np.linalg.norm(...) result in float(...) and updates the return annotation to float | np.ndarray, matching the actual runtime type returned for single-point inputs (repo requires Python ≥3.11, so the X | Y union syntax is fine).
  • tests/test_grid.py / tests/test_coordinates.py: assertions updated to match (isinstance(..., float) instead of np.floating, and a now-unneeded # ty: ignore[unsupported-operator] comment removed).

The branch logic (multi-point vs single-point) and docstring are unchanged and remain accurate. No repo CLAUDE.md/REVIEW.md found to check against. No prior review comments to reconcile with.

@claudio525
claudio525 merged commit 99702c1 into master Aug 11, 2026
6 checks passed
@claudio525
claudio525 deleted the typing_fix branch August 11, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants