Add stoch writing routine - #76
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds write support for stochastic slip model (“stoch”) files in an EMOD3D-compatible fixed-width format, and updates the StochFile API to support both parsing from disk and in-memory construction—needed to simplify the downstream Python port of srf2stoch.
Changes:
- Refactors
StochFileinto a dataclass and introducesStochFile.from_file(...)for parsing. - Adds
StochFile.dump(...)to write stoch files with fixed-width headers and arrays. - Expands/updates the stoch test suite to cover exact formatting and round-trip/idempotency behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
source_modelling/stoch.py |
Introduces from_file() + dump() and refactors StochFile to support writing EMOD3D-compatible output. |
tests/test_stoch.py |
Updates construction to from_file() and adds comprehensive dump/round-trip/format tests. |
Comments suppressed due to low confidence (1)
source_modelling/stoch.py:195
- The from_file() docstring says it raises ValueError, but the implementation raises parse_utils.ParseError. This makes the public API documentation misleading for callers handling parse errors.
ValueError
If the number of planes specified in the file is not a positive integer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lispandfound
requested review from
AndrewRidden-Harper,
claudio525 and
joelridden
July 22, 2026 03:42
claudio525
approved these changes
Jul 22, 2026
joelridden
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for writing stoch files in an EMOD3D-compatible format. This is necessary for the Python port of srf2stoch. Necessary API change required to clean-up downstream implementation of srf2stoch tool.