Fix SRF writing logic - #77
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SRF read/write handling to align the Rust implementation with EMOD3D’s expected SRF layout, particularly around PLANE header line breaks and stricter parsing.
Changes:
- Split PLANE header writing into two lines after the 6th value to match EMOD3D formatting.
- Tightened SRF parsing by requiring an end-of-line after the 6th PLANE header token (
wid), rejecting legacy one-line headers. - Updated and expanded fixtures/tests to reflect the new header layout and validate multi-plane parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/srf_writer.rs |
Writes PLANE headers across two lines; updates writer tests/fixtures accordingly. |
src/srf_parser.rs |
Enforces newline after wid in PLANE headers; updates fixtures and adds a V1 multi-plane parsing test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewRidden-Harper
previously approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SRF read-write logic to be more consistent with what the C code expects. Now: