Vectorize Rrup and Rjb

[claudio525]

No description provided.

[claudio525]

@claude review

[Copilot]

Pull request overview

This PR updates the seismic source geometry distance APIs to support vectorized RRup and Rjb computations (computing distances for many points in one call), aligning the implementation and tests with array-based workflows.

Changes:

• Vectorize Plane.rrup_distance / Plane.rjb_distance and Fault.rrup_distance / Fault.rjb_distance to accept N×3 point arrays and return per-point distances.
• Update Hypothesis/property tests to exercise multi-point inputs and assert array outputs; add a single-point regression test for Plane.rjb_distance.
• Require shapely>=2.0 to use vectorized geometry construction (shapely.points).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/test_sources.py	Updates tests to validate vectorized RRup/Rjb behavior and adds a single-point Rjb regression test.
source_modelling/sources.py	Implements vectorized RRup/Rjb computations for Plane and Fault with scalar fallback for single-point inputs.
pyproject.toml	Bumps Shapely dependency to >=2.0 to support new vectorized Shapely usage.

Suppressed comments (3)

source_modelling/sources.py:857

• rjb_distance is vectorized and can return an array, but the return type annotation and docstring still say it returns a float. This is a public API/type contract mismatch.

    def rjb_distance(self, points: np.ndarray) -> float:
        """Return the closest projected distance between the fault and the points.

        Parameters
        ----------

source_modelling/sources.py:1401

• Fault.rjb_distance is vectorized and can return an array, but the return annotation/docstring still declare a float return. This should be updated to avoid misleading API consumers and type checking errors.

    def rjb_distance(self, points: np.ndarray) -> float:
        """Return the closest projected distance between the fault and the points.

        Parameters
        ----------

source_modelling/sources.py:1338

• Fault.rrup_distance now returns either a scalar or an array depending on the input shape, but it is still annotated/docstringed as returning float. Update the public contract to reflect the vectorized behavior.

    def rrup_distance(self, points: np.ndarray) -> float:
        """Compute RRup Distance between a fault and a point.

        Parameters
        ----------

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[claudio525]

@claude review