Fix minimum jumping depth - #80
Merged
Merged
Conversation
Contributor
Author
|
@claude review this PR please. |
|
Claude finished @lispandfound's task in 2m 35s —— View job Review complete ✅
Findings: 1 medium, 1 low
Everything else (the new |
AndrewRidden-Harper
previously approved these changes
Aug 24, 2026
AndrewRidden-Harper
left a comment
Contributor
There was a problem hiding this comment.
Some minor suggestions for comments
Co-authored-by: Andrew Ridden-Harper <52001209+AndrewRidden-Harper@users.noreply.github.com>
AndrewRidden-Harper
self-requested a review
August 24, 2026 02:10
AndrewRidden-Harper
approved these changes
Aug 24, 2026
AndrewRidden-Harper
left a comment
Contributor
There was a problem hiding this comment.
Thanks, excellent comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimum jumping depth was not being respecting in the source modelling jump point calculator. This fixes it so it can used in Cybershake.