Pad nz for free surface boundary condition - #129
Open
lispandfound wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates EMOD3D parameter generation to account for an extra free-surface padding layer in the velocity model grid (by increasing nz), and adds a pre-write validation that the referenced velocity model files match the expected (nx, ny, nz)-derived file sizes.
Changes:
- Pad
nzby+1when generating EMOD3D domain parameters. - Add
check_domain_against_velocity_model()to validatepmodfile/smodfile/dmodfilesizes and invoke it duringcreate_e3d_par.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+282
to
+294
| try: | ||
| for filename in [parameters.pmodfile, parameters.smodfile, parameters.dmodfile]: | ||
| velocity_model_file = velocity_model_ffp / filename | ||
| file_size = velocity_model_file.stat().st_size | ||
| if file_size != expected_file_size: | ||
| raise RuntimeError( | ||
| f"Velocity model file {velocity_model_file} does not have the expected size (expected: {expected_file_size}, found: {file_size})" | ||
| ) | ||
|
|
||
| except (OSError, FileNotFoundError) as e: | ||
| print( | ||
| f"WARNING: could not validate domain parameters against velocity model supplied:\n{e}" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complement to the velocity modelling PR: ucgmsim/velocity_modelling#59