Update broadband simulation to use BA18 + CB14 model from site amplification package - #130
Open
lispandfound wants to merge 9 commits into
Open
Update broadband simulation to use BA18 + CB14 model from site amplification package#130lispandfound wants to merge 9 commits into
lispandfound wants to merge 9 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the broadband simulation pipeline to use the BA2018 + CB2014 site amplification models from the site-calculation package, while refactoring bb-sim to operate lazily with dask/xarray for lower memory usage and adding metadata to outputs.
Changes:
- Refactors broadband merging to dask/xarray, including station-chunked processing and per-chunk site amplification + filtering.
- Adds signal resampling to handle LF/HF mismatched sample rates and embeds Vs30 + site amp parameters in output metadata.
- Introduces
SiteAmpModelenum and extends broadband parameter schemas/defaults to support BA2018/CB2014 selection.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| workflow/scripts/bb_sim.py | Reworks broadband merge to dask/xarray, adds resampling/alignment, and applies BA2018/CB2014 amplification from site-calculation. |
| workflow/schemas.py | Adds SiteAmpModel and tightens broadband parameter validation (including new taper params). |
| workflow/realisations.py | Updates BroadbandParameters dataclass to include fhightop, fmax, and typed site_amp_version. |
| workflow/default_parameters/v24_2_2_4/defaults.yaml | Removes per-version bb defaults (now inherited from root). |
| workflow/default_parameters/v24_2_2_2/defaults.yaml | Removes per-version bb defaults (now inherited from root). |
| workflow/default_parameters/v24_2_2_1/defaults.yaml | Removes per-version bb defaults (now inherited from root). |
| workflow/default_parameters/root/defaults.yaml | Adds/updates broadband defaults including BA2018 model selection and taper frequencies. |
| uv.lock | Adds site-calculation and updates lock entries accordingly. |
| pyproject.toml | Declares dependency on site-calculation>=2026.7.1. |
| tests/test_realisation.py | Updates broadband parameter serialization test for new fields and enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described, but I took the opportunity to further refactor bb-sim: