Include the velocity model's padding layer in e3d.par nz - #131
Merged
Conversation
velocity_modelling 29f2347 added a padding row to generated velocity models for EMOD3D's free-surface ghost layer. This is the downstream half of that change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AndrewRidden-Harper
requested review from
claudio525,
joelridden and
lispandfound
August 13, 2026 23:23
lispandfound
previously approved these changes
Aug 28, 2026
AndrewRidden-Harper
force-pushed
the
fix-nz-in-e3d-par
branch
from
August 28, 2026 04:52
415a556 to
085964f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
velocity_modelling 29f2347 added a padding layer for EMOD3D. This PR makes the
nzwritten into thee3d.parfiles consistent with thenz+1in the velocity model.