Random sampling of NSHM rupture magnitude

[lispandfound]

Generates a random draw of the magnitude when --magnitude-strategy is set to random.

[lispandfound]

@claude review

[Copilot]

Pull request overview

Adds support for sampling a random NSHM rupture magnitude when --magnitude-strategy is set to random, complementing the existing rupture propagation sampling strategy.

Changes:

• Introduces a magnitude_strategy CLI option intended to control how total rupture magnitude is chosen (median vs random draw).
• Extends default_magnitude_estimation to request a random magnitude draw via magnitude_scaling.area_to_magnitude(..., random=...).
• Seeds Python’s random RNG alongside NumPy to support reproducible random sampling.

Suppressed comments (2)

workflow/scripts/nshm2022_to_realisation.py:82

• default_magnitude_estimation adds a required strategy parameter, but the docstring’s Parameters section doesn’t describe it, which makes it hard to understand what "maximising" vs "random" means for magnitude sampling.

    components: "DisjointSet[str]",
    avg_rake: float,
    strategy: SamplingStrategy,
) -> dict[str, magnitude_scaling.BoldM]:

workflow/scripts/nshm2022_to_realisation.py:262

• The magnitude_strategy docstring says that "random" will choose a random rupture propagation tree, but this option is for magnitude sampling. This is likely a copy/paste error and could confuse CLI users.

    magnitude_strategy : SamplingStrategy, optional
        The strategy to use when sampling total rupture magnitude. "maximising"
        will choose the median rupture magnitude. "random" will choose a random
        rupture propagation tree.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[AndrewRidden-Harper]

Copilot has some comments, so just check those if you haven't already. Otherwise, it looks good

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

workflow/scripts/nshm2022_to_realisation.py:262

• The magnitude_strategy parameter docstring incorrectly says the "random" option chooses a random rupture propagation tree; it should describe random sampling of rupture magnitude.

        The strategy to use when sampling rupture propagation. "maximising" will
        choose the maximally likely rupture propagation tree. "random" will
        choose a random rupture propagation tree.