Pin nshmdb to 2025.12.1, compatible with this project's nshmdb.db - #147
Closed
AndrewRidden-Harper wants to merge 1 commit into
Closed
Pin nshmdb to 2025.12.1, compatible with this project's nshmdb.db#147AndrewRidden-Harper wants to merge 1 commit into
AndrewRidden-Harper wants to merge 1 commit into
Conversation
nshmdb>=2025.12.1 resolved to 2026.8.3, but 2026.8.1+ changed get_rupture_faults()'s query to select f.fault_system and requires NSHMDB to be used as a context manager -- neither matches the nshmdb.db this project's 293 realisations were actually built from (sha256 00e256480618cd15e11fbf744037d037bf3fc2d523fb977ee30e0b84a640bc57, see cs_nshm_2022 commit 646055c), whose fault table has no fault_system column, and predates the context-manager requirement. Verified: nshm2022_to_realisation.generate_realisation() now completes end-to-end against the real database (rupture 101091), unmodified -- no code change needed once the version is pinned to what the data actually matches. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tr4WwR6mYXdKrroQ3XKAnJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest nshmdb package is incompatible with the DB for generating realisations, so we pin to the most recent compatible version.