Adding notification_policy access in AndoirdMenifest file. Required for do n…#16
Open
sainish wants to merge 2 commits intoudacity:develop_branchfrom
Open
Adding notification_policy access in AndoirdMenifest file. Required for do n…#16sainish wants to merge 2 commits intoudacity:develop_branchfrom
sainish wants to merge 2 commits intoudacity:develop_branchfrom
Conversation
…ot disturb access
sainish
commented
Feb 6, 2018
Author
sainish
left a comment
There was a problem hiding this comment.
It will never be able to set silent mode because if condition is wrong in setRingerMode.
in this condiiton nm.isNotificationPolicyAccessGranted()
there shouldn't be !. Because if access is granted then try to change mode of ring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For do not disturb option ACCESS_NOTIFICATION_POLICY access is needed.